Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simulator should send action_status to bridge as ActionResponse #283

Merged
merged 1 commit into from
Sep 9, 2023
Merged

fix: simulator should send action_status to bridge as ActionResponse #283

merged 1 commit into from
Sep 9, 2023

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Sep 9, 2023 •
edited
Loading

Closes #

Changes

Why?

The action_status must be received and noted by bridge against current_action before being pushed to platform.

Trials Performed

  2023-09-09T07:23:36.638370Z  INFO uplink::collector::simulator: Successfully sent all action responses

  2023-09-09T07:23:36.638535Z  INFO uplink::base::bridge: Action response = ActionResponse { action_id: "1604", sequence: 10, timestamp: 1694244216638, state: "Completed", progress: 100, errors: [], done_response: None }

@de-sh de-sh merged commit 6e8746d into main Sep 9, 2023
2 checks passed
@de-sh de-sh deleted the fix-sim branch September 21, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@de-sh